refactor "group by" to use embedded documents #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
changed the title
timgraham
reviewed
Oct 21, 2024
django_mongodb/compiler.py
Outdated
| @@ -526,11 +494,13 @@ def get_combinator_queries(self): | |||
| for alias, expr in main_query_columns: | |||
| # Unfold foreign fields. | |||
| if isinstance(expr, Col) and expr.alias != self.collection_name: | |||
| ids[self._unfold_column(expr)] = expr.as_mql(self, self.connection) | |||
| if expr.alias not in ids: | |||
There was a problem hiding this comment.
Use ids = defaultdict(dict) to avoid this?
timgraham
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new approach to compute group by using get project. This implementation simplifies group by, now it does not need GROUP_SEPARATOR and fold and unfold method.
Currently the foreign field are compute like:
'_id': {'T3___age': '$T3.age', 'age': '$age', 'name': '$name'}With this changes:
'_id': {'T3': {'age': '$T3.age'}, 'age': '$age', 'name': '$name'}