add support for EmbeddedModelField #151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
embedded-model-field
branch
from
bec8461 to
a6479ba
Compare
|
Just want to make sure if we're copying code that we attribute it properly according to the django-nonrel license. |
|
Certainly. THIRD-PARTY-NOTICES could be amended. |
timgraham
force-pushed
the
embedded-model-field
branch
from
a6479ba to
a104694
Compare
timgraham
force-pushed
the
embedded-model-field
branch
2 times, most recently
from
cb50893 to
6019a25
Compare
Jibola
approved these changes
Oct 29, 2024
|
This is not at all ready for review. |
timgraham
force-pushed
the
embedded-model-field
branch
from
6019a25 to
df74d7b
Compare
timgraham
changed the title
timgraham
force-pushed
the
embedded-model-field
branch
from
df74d7b to
a52ad67
Compare
timgraham
force-pushed
the
embedded-model-field
branch
3 times, most recently
from
0db42ed to
09c1d69
Compare
WaVEV
reviewed
Nov 23, 2024
| return mql, key_transforms | ||
|
|
||
|
|
||
| def key_transform(self, compiler, connection): |
There was a problem hiding this comment.
maybe we should move this function into the KeyTransform as as_mql
timgraham
force-pushed
the
embedded-model-field
branch
from
6f44d29 to
da58861
Compare
timgraham
force-pushed
the
embedded-model-field
branch
from
e2947b8 to
dd65bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very limited work in progress.
No forms/admin support.
In progress schema change support.
Limited querying support (no field validation, no aggregation support).
fixes #103