Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to test TestPyPI before publishing to PyPI #223

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Publish to test TestPyPI before publishing to PyPI #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69a3c89
Publish to test TestPyPI before publishing to PyPI
blink1073 Jan 17, 2025
fd856e3
address review
blink1073 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/release-python.yml
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also remove this old reference to the test pypi API as well? It's on line 116 of the changed file.
repository_url: https://test.pypi.org/legacy/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the change reflected in the PR yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed to the wrong remote. 🤦🏼

Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ jobs:
with:
name: all-dist-${{ github.run_id }}
path: dist/
- name: Publish package distributions to TestPyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
skip-existing: true
- name: Publish package distributions to PyPI
if: startsWith(inputs.dry_run, 'false')
uses: pypa/gh-action-pypi-publish@release/v1
Expand Down Expand Up @@ -108,5 +113,4 @@ jobs:
silk_asset_group: ${{ env.SILK_ASSET_GROUP }}
evergreen_project: ${{ env.EVERGREEN_PROJECT }}
token: ${{ github.token }}
repository_url: https://test.pypi.org/legacy/
dry_run: ${{ inputs.dry_run }}
Loading