Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version using 5.0.0a0 #212

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Version using 5.0.0a0 #212

merged 2 commits into from
Jan 8, 2025

Conversation

Jibola
Copy link
Collaborator

@Jibola Jibola commented Jan 8, 2025

Reverting to 5.0a0 to get the automated versioning to release 5.0a0

@aclark4life
Copy link
Collaborator

I don't know if it's relevant here, but I'd expect 5.0.0a0

@timgraham
Copy link
Collaborator

Django has never used ".0" in version numbers, even "5.0.0" (final). I don't see a need for a micro version number in pre-release version numbers, especially because we're never going to have something like "5.0.1a1".

One thing I wasn't sure about when you mentioned your intention to release "alpha 0" is whether that's a thing. I've never seen a version like that on PyPI.

There's a mention of "a0" at https://peps.python.org/pep-0440/#implicit-pre-release-number.

It's not relevant for this situation, but Django's version utility treats "alpha 0" as a development version: https://github.com/django/django/blob/a9c79b462923ce366101db1b5a3fff3d1dad870c/django/utils/version.py#L37-L40

All that to say, if "alpha 0" isn't working with the automated tooling, I wouldn't be completely surprised.

Copy link
Collaborator

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jibola
Copy link
Collaborator Author

Jibola commented Jan 8, 2025

Based on the feedback here and checking what we do over in mongo-python-driver. I think the best marriage of the two ecosystems would be to switch to the 5.0.0a0 nomenclature.

Here's a pymongo 4.8.0b0 release that works within the semantic versioning.

@aclark4life
Copy link
Collaborator

@aclark4life aclark4life self-requested a review January 8, 2025 18:47
@Jibola Jibola changed the title Revert to 5.0a0 Version using 5.0.0a0 Jan 8, 2025
Copy link
Collaborator

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better!

@Jibola Jibola merged commit a9a51aa into main Jan 8, 2025
9 checks passed
@timgraham timgraham deleted the revert-50a0 branch January 8, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants