Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: fix golangci lint config #54

Merged
merged 2 commits into from
May 1, 2024
Merged

task: fix golangci lint config #54

merged 2 commits into from
May 1, 2024

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented May 1, 2024 •
edited
Loading

Proposed changes

  • Update to 1.56.2
  • Fix the config for govet
  • Remove maligned config since not enabled
  • Remove tagliatelle since this lib doens't need it (no serializable structs)
  • Enable perfsprint since this lib is mostly string operations and we can benefit of it

andreaangiolillo
andreaangiolillo approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit afa3b21 into main May 1, 2024
3 checks passed
@gssbzn gssbzn deleted the fix-golangci-config branch May 1, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @andreaangiolillo