Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve logging around local HTTP server listening MONGOSH-1917 #198

Merged
merged 3 commits into from
Nov 19, 2024
Merged

chore: improve logging around local HTTP server listening MONGOSH-1917 #198

merged 3 commits into from
Nov 19, 2024

Conversation

addaleax
Copy link
Contributor

No description provided.

@addaleax addaleax requested a review from nirinchev November 19, 2024 19:05
nirinchev
nirinchev approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Was just looking at that HELP ticket and the extra logging would definitely be super helpful to get to the bottom of it. There's one eslint complaint in the tests, so might want to suppress it or rework the code a bit to avoid it.

@addaleax addaleax merged commit 6b72614 into main Nov 19, 2024
15 checks passed
@addaleax addaleax deleted the 1917-dev branch November 19, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirinchev nirinchev nirinchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @nirinchev