feat: add debug flag for dumping OIDC tokens to output MONGOSH-1845 #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabaasit
reviewed
Jul 31, 2024
packages/cli-repl/src/cli-repl.ts
Outdated
Comment on lines
1272
to
1274
| Buffer.from(part, 'base64url') | ||
| .toString('base64url') | ||
| .replace(/=+$/, '') === part |
There was a problem hiding this comment.
Trying to understand what does this condition ensure? 🤔
There was a problem hiding this comment.
Yeah, added a comment here 🙂 This bit is trying to validate that the parts are base64url-encoded (required for JWTs) by decoding it from base64url and re-encoding it back, then checking whether that's equal to the original string
mabaasit
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2109, not logically but since there are a number of adjacent source locations being modified, there are quite a few conflicts otherwise, plus on mongodb-js/oidc-plugin#194 for including the IdP server info