fix(compass): disable spellcheck before creating window when no network traffic COMPASS-8166 #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Apr 9, 2025
| // to 2001:4860:4860::8888 (the IPv6 address for Google Public DNS). | ||
| (target) => | ||
| !/^127.0.0.1:|^\[::1\]:/.test(target) && | ||
| !/^\[2001:4860:4860::8888\]:443$/.test(target) |
There was a problem hiding this comment.
And I guess this is something we can't control at all?
There was a problem hiding this comment.
I haven't found one yet.
It seems like electron command line switches redirect it with the host rules / host resolver rules.
https://www.electronjs.org/docs/latest/api/command-line-switches#--host-rulesrules
I'll spend a bit of time looking into that and circle back before merging.
lerouxb
reviewed
Apr 14, 2025
| // Passing a non-resolving URL prevents it from fetching | ||
| // as there aren't any options to disable it provided. | ||
| // https://github.com/electron/electron/issues/22995 | ||
| session.defaultSession.setSpellCheckerDictionaryDownloadURL( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-8166
We already were disabling the spellcheck when network traffic was disabled, however it looks like it was being disabled after the request for the dictionary would happen. This pr updates when we do the override to happen earlier.
The other change here is ignoring Google's public DNS ip in our no network test as its an expected functionality of chromium:
https://source.chromium.org/chromium/chromium/src/+/main:net/dns/README.md;l=351