Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e-tests): wait for modal to disappear COMPASS-8847 #6628

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented Jan 17, 2025

CI flake: https://spruce.mongodb.com/task/10gen_compass_main_test_packaged_app_macos_14_arm_test_packaged_app_3_patch_ba5c36f53031c6fcb1fc00d35830a2559c02c397_67895b4c81fc830007367944_25_01_16_19_17_36/logs?execution=0&sortBy=STATUS&sortDir=ASC

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Jan 17, 2025
@mabaasit mabaasit added the no release notes Fix or feature not for release notes label Jan 17, 2025
@mabaasit mabaasit changed the title fix(e2e-tests): wait for confirmation modal to disappear fix(e2e-tests): wait for modal to disappear COMPASS-8847 Jan 17, 2025
@mabaasit mabaasit marked this pull request as ready for review January 17, 2025 11:14
@mabaasit mabaasit merged commit dad4ed7 into main Jan 17, 2025
31 checks passed
@mabaasit mabaasit deleted the pipeline-confirmation-modal-flake branch January 17, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants