chore(e2e): remove the retry #6614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
the
no-title-validation
mabaasit
approved these changes
Jan 14, 2025
|
This CI run was green (which is pretty rare at the moment, but I suspect that's still just a coincidence) so I'm merging it. If it turns out that the flake we're seeing on mac arm64 really is just confined to the first time we start electron and we can't figure out why, then I think we can try to work around it by starting the app and immediately closing it before we start the tests. Then just catch any errors in that step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a suspicion that retry isn't helping and is actually making things worse. Let's see what happens in CI for this PR. We don't have to merge it and we can easily revert it too.