-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compass-crud): expand/collapse all COMPASS-8233 #6601
Conversation
buttonText={buttonText ?? 'Output Options'} | ||
buttonProps={{ | ||
size: 'xsmall', | ||
title: buttonText ?? 'Output Options', | ||
['aria-label']: buttonText ?? 'Output Options', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of duplicating this default value, did you consider moving it to the destructuring of the the props
above?
}> = ({ onChangeOption, buttonText = 'Output Options' }) => {
buttonText={buttonText ?? 'Output Options'} | |
buttonProps={{ | |
size: 'xsmall', | |
title: buttonText ?? 'Output Options', | |
['aria-label']: buttonText ?? 'Output Options', | |
buttonText={buttonText} | |
buttonProps={{ | |
size: 'xsmall', | |
title: buttonText, | |
['aria-label']: buttonText, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the prompt! I actually changed this so that the text default is "soft" (can be overridden with an empty string), but the aria label and title will still have a default.
</div> | ||
<div className={pipelinePaginationStyles}> | ||
<PipelinePagination /> | ||
<PipelineOutputOptionsMenu | ||
buttonText="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that default value be revisited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be. There are some other usages and I couldn't find them, that's why I chose not to change the default behaviour
Description
COMPASS-8233
Document Tab
Aggregations Tab
Fixing alignment of prev/next controls.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes