Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compass-crud): expand/collapse all COMPASS-8233 #6601

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Jan 10, 2025

Description

COMPASS-8233

Document Tab

  • Adding expand/collapse all documents controls (as per designs)
  • The menu is disabled for table view, because it has no effect there

Aggregations Tab

  • The menu was already there, moving the position and removing text (as per designs and to be consistent with the document view)

Fixing alignment of prev/next controls.

Screenshot 2025-01-10 at 16 28 44 Screenshot 2025-01-10 at 16 29 14

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Jan 10, 2025
@paula-stacho paula-stacho marked this pull request as ready for review January 10, 2025 15:35
Comment on lines 27 to 31
buttonText={buttonText ?? 'Output Options'}
buttonProps={{
size: 'xsmall',
title: buttonText ?? 'Output Options',
['aria-label']: buttonText ?? 'Output Options',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating this default value, did you consider moving it to the destructuring of the the props above?

}> = ({ onChangeOption, buttonText = 'Output Options' }) => {
Suggested change
buttonText={buttonText ?? 'Output Options'}
buttonProps={{
size: 'xsmall',
title: buttonText ?? 'Output Options',
['aria-label']: buttonText ?? 'Output Options',
buttonText={buttonText}
buttonProps={{
size: 'xsmall',
title: buttonText,
['aria-label']: buttonText,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the prompt! I actually changed this so that the text default is "soft" (can be overridden with an empty string), but the aria label and title will still have a default.

</div>
<div className={pipelinePaginationStyles}>
<PipelinePagination />
<PipelineOutputOptionsMenu
buttonText=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that default value be revisited?

Copy link
Contributor Author

@paula-stacho paula-stacho Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be. There are some other usages and I couldn't find them, that's why I chose not to change the default behaviour

@paula-stacho paula-stacho merged commit 1bc37cc into main Jan 13, 2025
32 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8233 branch January 13, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants