chore(e2e): Package and publish e2e docker image #6384
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syn-zhu
commented
Oct 21, 2024
| @@ -528,3 +534,9 @@ for (const compassDistribution of COMPASS_DISTRIBUTIONS) { | |||
| - func: create_static_analysis_report | |||
| vars: | |||
| first_party_dependency_filenames: <%= firstPartyDepsFilenames.map(f => '.sbom/' + f).join(',') %> | |||
|
|
|||
| - name: publish-e2e-tests | |||
| tags: ['run-on-pr'] | |||
There was a problem hiding this comment.
TODO: remove this before merging, turned it on for now just to test
There was a problem hiding this comment.
Can we do a "dry run" to confirm that it's working on PRs?
gribnoysup
reviewed
Oct 22, 2024
| echo "e2e tests image built" | ||
|
|
||
| # skip if the image already exists | ||
| if aws ecr describe-images --region $ECR_REGION --repository-name=compass/e2e-tests --image-ids=imageTag=$github_commit; then |
There was a problem hiding this comment.
I asked in the slack, but why are we using ecr and not artifactory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CLOUDP-274595
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes