-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RPC api calls for integrated address #134
base: main
Are you sure you want to change the base?
Conversation
src/lib.rs
Outdated
pub async fn make_integrated_address( | ||
&self, | ||
standard_address: Option<String>, | ||
payment_id: Option<String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other functions are using types from monero-rs when available. Same for the return types, parse them in make_integrated_address and return monero-rs types.
done. should be okay. |
Is this new API good in your use case ? If yes then LGTM and we can go ahead with this impl |
rather good, but I haven't yet used any code related to it in production. in general, it's a bit of a shame that you can't receive information about new payments via websocket and just setting up monero-wallet-rpc is bothersome but it's probably my fault because I didn't use docker |
Hello. I am new to Monero, but I was measuring myself today with the implementation of the payment system. I looked through the monero-wallet-rpc documentation and these two features were missing, so I added them. Perhaps it is possible to do it "around". but after adding these functions the payment prototype looks more or less like this:
Some types may not quite match, but I'm not very familiar with this project yet.