Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove old resolver #1516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🧹 Remove old resolver #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c0a4bd
🧹 Remove old resolver
jaym Dec 14, 2024
5a36396
fix tests
jaym Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions policy/bundle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,7 @@ func BundleExecutionChecksum(ctx context.Context, policy *Policy, framework *Fra
// So far the checksum only includes the policy and the framework
// It does not change if any of the jobs changes, only if the policy or the framework changes
// To update the resolved policy, when we change how it is generated, change the incoporated version of the resolver
if IsNextGenResolver(ctx) {
res = res.Add(RESOLVER_VERSION_NG)
} else {
res = res.Add(RESOLVER_VERSION)
}
res = res.Add(RESOLVER_VERSION)

return res.String()
}
Expand Down Expand Up @@ -624,7 +620,7 @@ func (c *bundleCache) removeFailing(res *Bundle) {
group := policy.Groups[j]
group.Queries = explorer.FilterQueryMRNs(c.removeQueries, group.Queries)
group.Checks = explorer.FilterQueryMRNs(c.removeQueries, group.Checks)
if len(group.Queries)+len(group.Checks) > 0 {
if len(group.Policies)+len(group.Queries)+len(group.Checks) > 0 {
groups = append(groups, group)
}
}
Expand Down
Loading
Loading