Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add encryption to gcp storage bucket resource #5077

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

vjeffrey
Copy link
Contributor

@vjeffrey vjeffrey commented Jan 9, 2025

add encryption settings as a dict

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

3 207 tests  ±0   3 203 ✅ ±0   1m 47s ⏱️ -7s
  379 suites ±0       4 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit 4f4b523. ± Comparison against base commit fe27e2e.

♻️ This comment has been updated with latest results.

@vjeffrey vjeffrey marked this pull request as draft January 9, 2025 17:07
@vjeffrey vjeffrey marked this pull request as ready for review January 9, 2025 17:10
Copy link
Contributor

@scottford-io scottford-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @vjeffrey

gcp.project.storage.buckets: [
  0: {
    id: "luna-pov-roaf"
    encryption: {}
  }
  1: {
    id: "luna-common-23er45r--first"
    encryption: {}
  }
  2: {
    id: "luna-terraform-backend"
    encryption: {}
  }
]

@vjeffrey vjeffrey merged commit 9de84a0 into main Jan 9, 2025
17 checks passed
@vjeffrey vjeffrey deleted the vj/gcpstorageencr branch January 9, 2025 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants