Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine SPIRESEngine with GPT4AllEngine #168

Closed
caufieldjh opened this issue Aug 8, 2023 · 0 comments · Fixed by #306
Closed

Combine SPIRESEngine with GPT4AllEngine #168

caufieldjh opened this issue Aug 8, 2023 · 0 comments · Fixed by #306
Assignees
@caufieldjh
Labels
enhancement New feature or request

Comments

@caufieldjh
Copy link
Member

The SPIRESEngine and GPT4AllEngine are both child classes of KnowledgeEngine and there's a lot of redundancy between the two.
They may be combined into a single knowledge extractor. This would make it easier to define new extraction functions capable of using both local and remote LLMs.
@caufieldjh caufieldjh added the enhancement New feature or request label Sep 21, 2023
@caufieldjh caufieldjh self-assigned this Jan 3, 2024
@caufieldjh caufieldjh linked a pull request Jan 3, 2024 that will close this issue
Restructure SPIRESEngine to accomodate abstract model #306
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caufieldjh caufieldjh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restructure SPIRESEngine to accomodate abstract model monarch-initiative/ontogpt
1 participant
@caufieldjh