Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate "Add Account (advanced)" in WelcomeLogIn.swift #1246

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lissine0
Copy link
Contributor

@tmolitor-stud-tu
Copy link
Member

I don't like this. the welcome login screen should be easy to use for non-techies and advanced options should be hidden in a separate screen for tech savy people to use.

@lissine0
Copy link
Contributor Author

the welcome login screen should be easy to use for non-techies and advanced options should be hidden in a separate screen for tech savy people to use.

That's exactly how it is in this PR. The screenshots above are what's shown when Add Account (advanced) is selected from the settings. Normal Add Account is still the same as before.

What this PR does, is basing Add Account (advanced) on Add Account instead of Account Edit
It feels more natural this way.

@tmolitor-stud-tu
Copy link
Member

Ah okay, that's okay. But, for the advanced view, could you remove the logo and change the explanatory text at the top to something explaining that this is an advanced expert account creation menu?

@tmolitor-stud-tu
Copy link
Member

We should make the direct tls switch only accessible (e.g. enabled) if the hostname or port fields contain something...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants