Small improvements for slidge #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmolitor-stud-tu
requested changes
Sep 24, 2024
|
Current consensus is to add incoming messages from the bare jid of a muc as status messages into the history db. |
lissine0
force-pushed
the
improvements-for-slidge
branch
3 times, most recently
from
a1deead
to
64c9bc0
Compare
|
This needs a rebase |
XEP-0045 requires a room to - have an identity with category='conference' - advertise support for the 'http://jabber.org/protocol/muc' feature Thus it is more reliable to check for both of these things.
And classify them as status messages. Although underspecced, this is used in the wild.
lissine0
force-pushed
the
improvements-for-slidge
branch
from
64c9bc0
to
2004c49
Compare
|
I asked for a rebase because this PR contained already merged commits (the muc detection and muc name changes). Those don't belong into this PR, no? |
|
Ah! my fault! those were only merged into the (old)stable branch! |
tmolitor-stud-tu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.