Always show back button on mac catalyst #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because, whether we should display the back button is not necessarily dependent on the particular size class.
On iOS, you can dismiss modals by dragging down on them, or by tapping outside of the modal. The same affordances are not made on MacOS. This means that, if you open the contact details view on catalyst at the moment, it is impossible to close the view, since we have disabled showing the back button in AddTopLevelNavigation when the size class is regular (which is normally the case on MacOS). Therefore, if the current target is mac catalyst, we should always display back buttons on modals, so that users can dismiss them without having to force close the app. Thanks lissine for finding this, and suggesting how to fix it. Co-authored-by: lissine <[email protected]>
|
Wouldn't it be possible to use |
|
Okay, forget my comment. You exactly did what I had in mind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1205 introduced a regression on MacOS where, once a user opens the contact details view, they cannot close it, since there is no back button and clicking outside of the modal does nothing (unlike on iOS).
This PR works around this by always showing the back button in
AddTopLevelNavigation. The consequence of this is that we also show the back button in popovers (such as theContactsViewpopover)