-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftUI contact list #1205
SwiftUI contact list #1205
Commits on Aug 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 384ca7a - Browse repository at this point
Copy the full SHA 384ca7aView commit details -
Create wrapper for ContentUnavailableView.search
This convenience method is also not available in iOS 16, so we redefine it making use of our existing shim. The signature does not exactly match Apple's, but it's sufficiently similar that we can drop in the real version without changes when needed, simply by renaming the class being called.
Configuration menu - View commit details
-
Copy full SHA for e1282d6 - Browse repository at this point
Copy the full SHA e1282d6View commit details -
Create NumberlessBadge helper view
This is a reusable badge designed to be overlaid on top of Buttons when they have notifications.
Configuration menu - View commit details
-
Copy full SHA for f80b89a - Browse repository at this point
Copy the full SHA f80b89aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c69f272 - Browse repository at this point
Copy the full SHA c69f272View commit details -
Sorting is done via the contact's display name first, and by jid second.
Configuration menu - View commit details
-
Copy full SHA for 902587e - Browse repository at this point
Copy the full SHA 902587eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5673be3 - Browse repository at this point
Copy the full SHA 5673be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43893ce - Browse repository at this point
Copy the full SHA 43893ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for d45fec1 - Browse repository at this point
Copy the full SHA d45fec1View commit details -
Correct Add Group form spacing in popover
This view was shown incorrectly in certain situations when inside a popover. This commit introduces a workaround so that SwiftUI uses consistent spacing, whether the popover is presented as a popover or a sheet.
Configuration menu - View commit details
-
Copy full SHA for d0375b7 - Browse repository at this point
Copy the full SHA d0375b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2a09e - Browse repository at this point
Copy the full SHA 0e2a09eView commit details -
Add sizeClass to ActiveChatsViewController
This can be used to tell us whether we should display back buttons in popovers.
Configuration menu - View commit details
-
Copy full SHA for 6582b0b - Browse repository at this point
Copy the full SHA 6582b0bView commit details -
Update sizeClass on view controller size change
This makes sure the sizeClass in ActiveChatsViewController is always kept in sync with changes to the size class (e.g. when the size changes in split view).
Configuration menu - View commit details
-
Copy full SHA for dfff9c6 - Browse repository at this point
Copy the full SHA dfff9c6View commit details -
Only show back button when style class is compact
Apple guidelines state that we should only display a close button on a popover for confirmation or guidance. Therefore, there are some situations where we would like to display a popover without a close button. This commit allows us to only display the close button inside AddTopLevelNavigation when it is needed. Unfortunately, we have to retrieve the size class from the active chats view controller. It doesn't work to use @Environment(\.horizontalSizeClass) within AddTopLevelNavigation, since this will always display as compact within the popover itself.
Configuration menu - View commit details
-
Copy full SHA for 3bd10ff - Browse repository at this point
Copy the full SHA 3bd10ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c6f9a9 - Browse repository at this point
Copy the full SHA 6c6f9a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f1bf8b - Browse repository at this point
Copy the full SHA 8f1bf8bView commit details -
Animate group member list changes
We only animate additions and removals from the group here. Animating presence changes (e.g. fading the opacity in and out) and affiliation changes is still to do, as it requires a larger refactor.
Configuration menu - View commit details
-
Copy full SHA for 8ff851d - Browse repository at this point
Copy the full SHA 8ff851dView commit details