Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftUI contact list #1205

Merged

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    384ca7a View commit details
    Browse the repository at this point in the history
  2. Create wrapper for ContentUnavailableView.search

    This convenience method is also not available in iOS 16, so we redefine
    it making use of our existing shim.
    
    The signature does not exactly match Apple's, but it's sufficiently
    similar that we can drop in the real version without changes when
    needed, simply by renaming the class being called.
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e1282d6 View commit details
    Browse the repository at this point in the history
  3. Create NumberlessBadge helper view

    This is a reusable badge designed to be overlaid on top of Buttons when
    they have notifications.
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    f80b89a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c69f272 View commit details
    Browse the repository at this point in the history
  5. Sort contacts in ContactsView

    Sorting is done via the contact's display name first, and by jid
    second.
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    902587e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5673be3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    43893ce View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d45fec1 View commit details
    Browse the repository at this point in the history
  9. Correct Add Group form spacing in popover

    This view was shown incorrectly in certain situations when inside a
    popover. This commit introduces a workaround so that SwiftUI uses
    consistent spacing, whether the popover is presented as a popover or a
    sheet.
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    d0375b7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0e2a09e View commit details
    Browse the repository at this point in the history
  11. Add sizeClass to ActiveChatsViewController

    This can be used to tell us whether we should display back buttons in
    popovers.
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6582b0b View commit details
    Browse the repository at this point in the history
  12. Update sizeClass on view controller size change

    This makes sure the sizeClass in ActiveChatsViewController is always
    kept in sync with changes to the size class (e.g. when the size changes
    in split view).
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    dfff9c6 View commit details
    Browse the repository at this point in the history
  13. Only show back button when style class is compact

    Apple guidelines state that we should only display a close button on a
    popover for confirmation or guidance. Therefore, there are some
    situations where we would like to display a popover without a close
    button.
    
    This commit allows us to only display the close button inside
    AddTopLevelNavigation when it is needed.
    
    Unfortunately, we have to retrieve the size class from the active chats
    view controller. It doesn't work to use
    @Environment(\.horizontalSizeClass) within AddTopLevelNavigation, since
    this will always display as compact within the popover itself.
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    3bd10ff View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6c6f9a9 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    8f1bf8b View commit details
    Browse the repository at this point in the history
  16. Animate group member list changes

    We only animate additions and removals from the group here. Animating
    presence changes (e.g. fading the opacity in and out) and affiliation
    changes is still to do, as it requires a larger refactor.
    matthewrfennell committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    8ff851d View commit details
    Browse the repository at this point in the history