Added Switch single and dual tatacon functionality #2

drFerg · 2018-09-26T16:30:03Z

Let me know if you want me to add or remove anything.

The changes are fairly confined to it's own firmware. The keyboard firmware is only updated to support the new function signatures in the updated lufa.

- Mimics the Pokken Controller which is a Pro Controller. - Currently doesn't perform debouncing like original firmware. - When plugged in, it performs the L + R, A combo to be synced. - Uses L, R, LSTICK, RSTICK, for Dons and Kats - Needs to be fixed to use stored config - Performed some code cleanup, needs to be further refactored

- Added relevant vendor/product ids to manifest - Updated code to support V0 (OSU) and V2 (Switch) - Correctly updates configuration based on version, as versions use differing configuration layouts and sizes

- Like Keyboard firmware, supports Joystick and HID configuration - Switch firmware now supports custom button assignment based on the switch pro controller buttons - Added debouncing back to match keyboard firmware - Updated makefile to add usbclass for configuration

- Added both C(unix) and Python(windows) versions - Updated makefiles to flash using these tools

- Duplicates the interface and endpoints to add a second controller - Drum output depends on which interface reads it first, but it's just a proof-of-concept

mon · 2018-09-27T01:24:04Z

As I've mentioned before, outstanding work.

Google is deprecating Chrome web apps (I think they're due to break this year), so I wasn't going to continue working on the configurator - I'm currently rewriting using C and hidapi. Trying to find a nice "easy" Linux+Windows toolkit for a UI, but the CLI is almost done.

Having a third VID/PID pair is annoying - can you confirm that you must have the Hori VID/PID for the switch to recognise the controller? Or is it just the descriptors that matter?

I definitely want a unified firmware, but I'm committed to doing that work myself (and finally have some time to achieve it), so no worries there.

It's also excellent to hear that 2-player works, and I guess I'll start designing a new 2-port PCB for that goal.

I see you've enabled the "let mon commit to your repo" option, so any merging/adjustments I'll put in there until it's ready for release.

mon · 2018-12-16T06:01:19Z

I just bought a switch. Expect this to be merged sooner rather than later.

drFerg · 2018-12-17T13:43:50Z

Great news! Apologies I never got back to you, I got sidetracked by life haha. Looking forward to seeing progress.

renanyuu · 2020-06-18T11:19:41Z

Hi
Whats the status on this?

YaelBx

Tried your work today thank you for this huge contribution !
Had a couple of issues, can you take a look to them ?
Looking forward to hearing your feedbacks :)

Thanks again,
Yaël B.

YaelBx · 2020-08-19T16:28:27Z

Firmware/SwitchPro/Joystick.h

+// Type Defines
+// Enumeration for joystick buttons.
+typedef enum {
+	SWITCH_Y       = 0x01,


Hi,
Looking at my Pro Controller inputs through Windows internal controller calibration system, it seems like I found instead

SWITCH_B = 0x01, SWITCH_A = 0x02, SWITCH_Y = 0x04,

Are you sure of those values ? :)

YaelBx · 2020-08-19T16:31:19Z

Firmware/SwitchPro/makefile

+	$(AVRDUDE) -U flash:w:DFU/BootloaderHID.hex:i
+
+flash: all
+	sleep 1


"sleep" command is not recognized by Windows cmd

YaelBx · 2020-08-19T16:35:19Z

Firmware/SwitchPro/makefile

+
+flash: all
+	sleep 1
+	python2 DFU/hid_bootloader_loader.py atmega16u2 Joystick.hex


python instead ?

YaelBx · 2020-08-19T21:31:41Z

Firmware/SwitchPro/Joystick.c

+            }
+            report_count++;
+            break;
+        case TATACON_PASSTHROUGH:


Something really fishy around here.

Pads were triggering a lot of buttons, including Home, which shouldn't happen at all.
Hard for me to catch the source and find a workaround without a proper debugger... :(

Also, I have almost always double triggering, which should be because of my Tatacon, but debounce (set to 4000 to check if anything happen) seems to do nothing....

Small and dirty workaround I did for the button (didn't found for the debounce yet):

Suggested change

case TATACON_PASSTHROUGH:

case TATACON_PASSTHROUGH:

// Get tatacon button data

data = nunchuck_readByte(BUTTONS_DATA);

CLEAR(LED_PORT, KAT_LED_PIN);

CLEAR(LED_PORT, DON_LED_PIN);

// Tatacon has 4 inputs to check

for(i = 0; i < TATACON_SWITCHES; i++) {

// The I2C data starts at the 6th bit and goes down

uint8_t newState = !(data & _BV(TATACON_BUTTONS_START - i));

if(!switches[i].debounce && switches[i].state != newState) {

switch(i) {

case 0 :

reportData->Button |= SWITCH_LCLICK;

SET(LED_PORT, DON_LED_PIN);

break;

case 1 :

reportData->Button |= SWITCH_ZL;

SET(LED_PORT, KAT_LED_PIN);

break;

case 2 :

reportData->Button |= SWITCH_RCLICK;

SET(LED_PORT, DON_LED_PIN);

break;

case 3 :

reportData->Button |= SWITCH_ZR;

SET(LED_PORT, KAT_LED_PIN);

break;

}

switches[i].state = newState;

switches[i].debounce = tataConfig.debounce;

switchesChanged = 1;

}

}

break;

YaelBx · 2020-08-19T21:33:14Z

Firmware/SwitchPro/Joystick.c

+            else if (report_count == 25 || report_count == 50) {
+                reportData->Button |= SWITCH_L | SWITCH_R;
+            }
+            else if (report_count == 75 || report_count == 100) {


A bit too quick for the switch to catch the A button :)
I set my second value to 200 instead of 100, seems to do the trick

drFerg added 15 commits September 5, 2018 10:58

Updated LUFA version to support Switch

c457c3a

Updated Chrome webapp to support Switch Hori Controller

b078a43

- Added relevant vendor/product ids to manifest - Updated code to support V0 (OSU) and V2 (Switch) - Correctly updates configuration based on version, as versions use differing configuration layouts and sizes

Updated readme with Linux udev help

b7648ce

Updated readme with Nintendo Switch info

c332e6d

Updated debouncing to match keyboard firmware

b4cb8db

Updated keyboard firmware to current LUFA version

03335b6

Changed configuration app to recognise existing version 0.1 firmware

6d383b8

Added LUFA dfu hid tools needed for updating firmware

a0f0e2f

- Added both C(unix) and Python(windows) versions - Updated makefiles to flash using these tools

Updated readme with more info on compiling and installing firmware

14a0968

Updated readme with more Nintendo Switch info

eb6ea9f

Fixed endpoint overlap for Switch joystick and configuration

2b4734e

Updated default Switch mapping to use ZL + ZR to also navigate with

9a6b043

Added a proof-of-concept version implementing 2 pro controllers

a6662b3

- Duplicates the interface and endpoints to add a second controller - Drum output depends on which interface reads it first, but it's just a proof-of-concept

YaelBx suggested changes Aug 19, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Switch single and dual tatacon functionality #2

Added Switch single and dual tatacon functionality #2

drFerg commented Sep 26, 2018

mon commented Sep 27, 2018

mon commented Dec 16, 2018

drFerg commented Dec 17, 2018

renanyuu commented Jun 18, 2020

YaelBx left a comment

YaelBx Aug 19, 2020

YaelBx Aug 19, 2020

YaelBx Aug 19, 2020

YaelBx Aug 19, 2020

YaelBx Aug 19, 2020

-        case TATACON_PASSTHROUGH:
+case TATACON_PASSTHROUGH:
+            // Get tatacon button data
+            data = nunchuck_readByte(BUTTONS_DATA);
+            CLEAR(LED_PORT, KAT_LED_PIN);
+            CLEAR(LED_PORT, DON_LED_PIN);
+            // Tatacon has 4 inputs to check
+            for(i = 0; i < TATACON_SWITCHES; i++) {
+                // The I2C data starts at the 6th bit and goes down
+                uint8_t newState = !(data & _BV(TATACON_BUTTONS_START - i));
+                if(!switches[i].debounce && switches[i].state != newState) {
+                    switch(i) {
+                        case 0 :
+                        reportData->Button |= SWITCH_LCLICK;
+                        SET(LED_PORT, DON_LED_PIN);
+                        break;
+                        case 1 :
+                        reportData->Button |= SWITCH_ZL;
+                        SET(LED_PORT, KAT_LED_PIN);
+                        break;
+                        case 2 :
+                        reportData->Button |= SWITCH_RCLICK;
+                        SET(LED_PORT, DON_LED_PIN);
+                        break;
+                        case 3 :
+                        reportData->Button |= SWITCH_ZR;
+                        SET(LED_PORT, KAT_LED_PIN);
+                        break;
+                    }
+                    switches[i].state = newState;
+                    switches[i].debounce = tataConfig.debounce;
+                    switchesChanged = 1;
+                }
+            }
+            break;

Added Switch single and dual tatacon functionality #2

Are you sure you want to change the base?

Added Switch single and dual tatacon functionality #2

Conversation

drFerg commented Sep 26, 2018

mon commented Sep 27, 2018

mon commented Dec 16, 2018

drFerg commented Dec 17, 2018

renanyuu commented Jun 18, 2020

YaelBx left a comment

Choose a reason for hiding this comment

YaelBx Aug 19, 2020

Choose a reason for hiding this comment

YaelBx Aug 19, 2020

Choose a reason for hiding this comment

YaelBx Aug 19, 2020

Choose a reason for hiding this comment

YaelBx Aug 19, 2020

Choose a reason for hiding this comment

YaelBx Aug 19, 2020

Choose a reason for hiding this comment