Tokens for UTSlider #222
Tokens for UTSlider #222
Conversation
| @@ -0,0 +1,44 @@ | |||
| { | |||
There was a problem hiding this comment.
let's put this in platformcomponents/desktop as mobile has this component (https://www.figma.com/file/z6oi9Ku3X7rM1Wj2451B9u/Components---Android?node-id=11917%3A56753) but the colors are not the same
| "slider": { | ||
| "comment": "applies to sliders", | ||
| "figma": "https://www.figma.com/file/NaNrfXjygZtRgMfHAFHjsp/Components---Windows?node-id=46518%3A104257", | ||
| "track-empty": { |
There was a problem hiding this comment.
why not grouping like:
"track":{
"empty": ...,
"full": ...
}
| "background": "@theme-control-active-normal" | ||
| }, | ||
| "#disabled": { | ||
| "background": "@theme-control-active-disabled" |
There was a problem hiding this comment.
I cannot find this one in the component's Figma. It is a darker blue, in theory. But cannot see it. When I see a full track disabled, I find @theme-control-inactive-disabled assigned to the full track (both the full and the empty track overlap, making the full track look lighter than the empty one
| "background": "@theme-background-solid-primary-normal", | ||
| "border": "@theme-outline-primary-normal" | ||
| }, | ||
| "#hovered": { |
There was a problem hiding this comment.
we do not have a hover state in the component's figma, right? do we need to create one in the repo? if yes, we should we ask the momentum team to add this state to their Figma
| }, | ||
| "#focused": { | ||
| "background": "@theme-background-solid-primary-normal", | ||
| "border": "@theme-control-active-normal" |
There was a problem hiding this comment.
is this in the component figma? cannot find it
| }, | ||
| "#disabled": { | ||
| "background": "@theme-background-solid-tertiary-normal", | ||
| "border": "@theme-background-solid-tertiary-normal" |
There was a problem hiding this comment.
you can put "border": "none". "none" is a keyword that makes the "background" colour of that object be assigned to its "border". The output is the same as you have here, but it is just more readable that this handle has no border on disabled.
Guide
This "Help" section can be deleted before submitting this pull request.
Update the name of this pull request to reflect the following shape:
Provide a general summary of the scope of the changes in this pull request.
Description
The full description of the changes made in this request.
Links
Links to relevent resources.