add button-secondary-active token #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add checked state for ghost button token
paulwitty
reviewed
Nov 10, 2021
| @@ -41,6 +41,24 @@ | |||
| "background": "@theme-button-secondary-normal", | |||
| "text": "@theme-text-primary-disabled", | |||
| "border": "@theme-outline-disabled-normal" | |||
| }, | |||
| "active": { | |||
There was a problem hiding this comment.
We can't nest active inside secondary, because secondary is an object with the different UI states within it. Can you move this up a level and rename it to something else please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add checked state for ghost button token
Guide
This "Help" section can be deleted before submitting this pull request.
Update the name of this pull request to reflect the following shape:
Provide a general summary of the scope of the changes in this pull request.
Description
The full description of the changes made in this request.
Links
Links to relevent resources.