Skip to content

fix: buttonpill migration #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cscheffauer
Copy link
Collaborator

@cscheffauer cscheffauer commented May 19, 2025

Description

  • Migrating the ButtonPill component to use the new momentum-design component
  • Update unit tests respectively

@cscheffauer cscheffauer added the validated If the pull request is validated automation. label May 19, 2025
Copy link
Collaborator

@maxinteger maxinteger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some storybook deferences:

  1. ButtonPill - Ghost Not Outline Not inverted: image
  2. ButtonPill - Not Ghost Outline Not inverted: image
  3. ButtonPill - Not Ghost Outline inverted: image
  4. ButtonPill - Ghost Outline Not inverted image
  5. ButtonPill - Not Ghost Outline inverted: image

@cscheffauer cscheffauer force-pushed the fix-buttonpill-migration branch from 7fab1d4 to 36d5d51 Compare May 23, 2025 09:05
@cscheffauer cscheffauer merged commit 413c822 into momentum-design:master May 23, 2025
5 checks passed
Copy link

🎉 This PR is included in version 26.204.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released validated If the pull request is validated automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants