fix(TabsProvider): remove uuidv4 call every render #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccarrington
added
the
validated
gabrielchl
reviewed
Nov 14, 2024
| @@ -10,7 +10,8 @@ import { TabsProviderContext } from './TabsProvider.utils'; | |||
| const TabsProvider: FC<Props> = (props: Props) => { | |||
| const { selectedTab, id: _id, children } = props; | |||
|
|
|||
| const [id] = useState(_id || uuidv4()); | |||
There was a problem hiding this comment.
i don't believe the original implementation here is calling the uuidv4 function on every render.
useState only evaluates the initial state once on first render, then keep tracks of the value internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description