Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbar): missing aria orientation attribute #669

Conversation

gabrielchl
Copy link
Collaborator

Description

it was once missing, now it's not

Links

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-569589

@gabrielchl gabrielchl marked this pull request as ready for review October 14, 2024 09:25
@dominiccarrington dominiccarrington added the validated If the pull request is validated automation. label Oct 14, 2024
Copy link
Collaborator

@dominiccarrington dominiccarrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielchl gabrielchl merged commit e55e743 into master Oct 14, 2024
10 checks passed
Copy link

🎉 This PR is included in version 26.171.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released validated If the pull request is validated automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants