fix: add close button accessible name props to ToastNotification #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,8 @@ import Text from '../Text'; | |||
| * The ToastNotification component. | |||
| */ | |||
| const ToastNotification: FC<Props> = (props: Props) => { | |||
| const { className, id, style, content, leadingVisual, buttonGroup, onClose } = props; | |||
| const { className, id, style, content, leadingVisual, buttonGroup, onClose, closeButtonLabel } = | |||
There was a problem hiding this comment.
I think this case gives us the perfect opportunity to have a default arialabel for the button "Close notification". X buttons in notification toasts, if pressent, will always need an aria label. So if we are making this prop optional (which is good imo), then we should add a default value.
add default label to the close button
nataliadelmar
approved these changes
May 17, 2024
maxinteger
deleted the
fix/SPARK-505339-add-toastnotification-close-btn-label-prop
branch
|
🎉 This PR is included in version 26.101.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new prop to ToastNotification to fix the missing accessible label on the close button
Links
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-505339