Vite static build #1841
Merged
Vite static build #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 27, 2025 08:48
The build does a mandatory type-check now.
Results and the popularity json file stay at their current place. So if someone wanted to gather all the historical benchmark data, one wont have to deal with too many files moving around.
This app is separated from the benchmark script stuff so it should have its own eslint and rules.
It did include the docs app.
moltar
approved these changes
Apr 28, 2025
|
Just fixed a small path typo in the README, shouldn't need a re-review 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Vite to build the benchmark viewer app. Fixes #1735.
Testing
Deployed the viewer app here
Checklist
[ ] Added tests to validate the functionality or fix.