Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default units for viscosity and fixed a bug in handling dimensions #61

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

paulsaxe
Copy link
Collaborator

@paulsaxe paulsaxe commented Aug 2, 2024

  • Added more default units: dynamic viscosity (cP, etc) and kinematic viscosity (cSt, etc)
  • Fixed a bug handling unit dimensions since the order changed in Pint. Now they are put in a standard alphabetical order.

* Added more default units: dynamic viscosity (cP, etc) and kinematic viscosity
  (cSt, etc)
* Fixed a bug handling unit dimensions since the order changed in Pint. Now they are
  put in a standard alphabetical order.
@paulsaxe paulsaxe added bug Something isn't working enhancement New feature or request labels Aug 2, 2024
@paulsaxe paulsaxe requested a review from seamm August 2, 2024 14:52
Copy link
Contributor

@seamm seamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seamm seamm merged commit 77d391b into main Aug 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants