Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): typo in function name #500

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(readme): typo in function name #500

merged 1 commit into from
Dec 20, 2024

Conversation

kruschid
Copy link
Contributor

The readme section above the updated code fragment says that location changes are applied by calling navigate. However, in the code, the function was named setLocation. This PR renames setLocation to navigate in the example for better clarity.
(Generally, I would prefer navigate over setLocation. setLocation could be misunderstood as a state setter, whereas navigate is more specific by pointing out the side effect. This is just an opinion. :-))

Copy link

stackblitz bot commented Dec 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (48b63a9) to head (7c10e8b).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #500   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@molefrog
Copy link
Owner

Thanks, good suggestion!

@molefrog molefrog merged commit 4497eca into molefrog:v3 Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants