fix wouter link to prevent crash without href/to

molefrog · Aug 28, 2024 · 4162953 · 4162953
1 parent ab46b00
commit 4162953
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/wouter/src/index.js b/packages/wouter/src/index.js
@@ -265,7 +265,9 @@ export const Link = forwardRef((props, ref) => {
 
   // handle nested routers and absolute paths
   const href = router.hrefs(
-    targetPath[0] === "~" ? targetPath.slice(1) : router.base + targetPath,
+    (targetPath ?? "")[0] === "~"
+      ? targetPath.slice(1)
+      : router.base + targetPath,
     router // pass router as a second argument for convinience
   );
 

diff --git a/packages/wouter/test/link.test.tsx b/packages/wouter/test/link.test.tsx
@@ -322,4 +322,17 @@ describe("<Link /> with `asChild` prop", () => {
     expect(link).toHaveAttribute("href", "/about");
     expect(link).toHaveTextContent("Click Me");
   });
+
+  it("missing href or to won't crash", () => {
+    const { getByText } = render(
+      /* @ts-expect-error */
+      <Link>Click Me</Link>
+    );
+
+    const link = getByText("Click Me");
+
+    expect(link.tagName).toBe("A");
+    expect(link).toHaveAttribute("href", undefined);
+    expect(link).toHaveTextContent("Click Me");
+  });
 });