Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: populate param parsing #394

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Freezystem
Copy link
Contributor

I just noticed that params used in the getNativeVirtualPopulateQuery weren't the sanitized ones.
So I've added a parameter to pass the sanitized params along with the context.

One question remains though:

Why are we not directly altering ctx.params from the context instead of passing a sanitized value along with the context in methods ? It would avoid passing an additional parameter and prevent mistaking original params for sanitized ones.

@Freezystem
Copy link
Contributor Author

@icebob Can I have your review and opinion on this one ? 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant