Do not get UPPERCASE env vars

[wheezil]

We hit this issue when we updated MSBuild to latest VS2022.
The problem original appears to be simply that maven-exec-plugin was adding both
EnvironmentVariable
and its twin that differs only by case
ENVIRONMENTVARIABLE
which was indeed a problem. However, simply removing the duplicates didn't work, because MSBuild is "special". Apparently, if you have an env var like OneDrive and maven-exec-plugin turns that into ONEDRIVE for the launched process environment block, MSBuild somehow finds the original env var definitions (in the registry?) and attempts to add them. It doesn't detect the duplicate that differs only in case until it is too late and it errors out as described in this MS bug report
The answer is trivially simple -- don't UPPERCASE the env vars

[wheezil]

@slawekjaranowski thanks I made that change

[slawekjaranowski]

please rebuild project with JDK 11+ to see errors from spotless

[slawekjaranowski]

Please also look at:
https://github.com/mojohaus/exec-maven-plugin/pull/427/files#diff-08636831c593bb3e17c86b9287a93a740b26c44a780252ddd4bf1537faddf3ebR496-R501

we can have a duplicate keys like Path and PATH

[slawekjaranowski]

Thera is also environmentVariables parameters
https://www.mojohaus.org/exec-maven-plugin/exec-mojo.html#environmentVariables

User can provide env values with different format

[slawekjaranowski]

@wheezil How's work going?

[wheezil]

Hi I am on vacation for a while, will get back to this in about a month

…

On Tue, May 21, 2024, 21:17 Slawomir Jaranowski ***@***.***> wrote: @wheezil <https://github.com/wheezil> How's work going? — Reply to this email directly, view it on GitHub <#427 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKXHCJKTCLGWU4AR6VBRJTZDOMVTAVCNFSM6AAAAABHRIE3RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGI4DKNRVGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[wheezil]

@slawekjaranowski how about now? The spotless plugin is flagging a bunch of files that are not my changes, but I did remove the unused import.

[dermot-hardy]

Hi. Is the SNAPSHOT version of the plugin that is built from this branch published anywhere? Thanks, Dermot.

[wheezil]

@dermot-hardy no I did not publish an artifact. We have one on our internal servers.
It is not hard to build the branch and give it whatever version you want locally. However, I had to disable the spotless plugin.

[dermot-hardy]

If it's an easy thing for you to do it would be much appreciated. I tried using https://jitpack.io/ but it looks like they use Maven 3.6.1 and this project requires Maven 3.6.3:
https://jitpack.io/com/github/wheezil/exec-maven-plugin/0731ed3780/build.log

[wheezil]

@slawekjaranowski Just seeing if this can be merged or is there something I have to do?

[dermot-hardy]

Just FYI I've forked your branch and added a couple of extra commits (see here) to allow it to build with Maven 3.8.1 so that I could get a https://jitpack.io/ build.

<pluginRepositories>
    <pluginRepository>
        <id>jitpack.io</id>
        <url>https://jitpack.io</url>
    </pluginRepository>
</pluginRepositories>

<plugin>
    <groupId>com.github.dermot-hardy</groupId>
    <artifactId>exec-maven-plugin</artifactId>
    <version>master-SNAPSHOT</version>
</plugin>

This should tie me over for now until your fix gets merged and released. Thank you.