Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with spaces in JAVACMD or CLASSPATH for windows batch scripts #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

opax
Copy link

@opax opax commented Mar 28, 2023

This should resolve issue #114 .
In addition to the quoted JAVACMD, CLASSPATH is also quoted so that spaces in the classpath do not crash the batch script.
The test expectations have been updated accordingly.

@opax opax closed this Mar 31, 2023
@opax opax changed the title Fix issue #114 Fix problem with spaces CLASSPATH for windows cmd scripts Mar 31, 2023
@opax opax changed the title Fix problem with spaces CLASSPATH for windows cmd scripts Fix problem with spaces in JAVACMD or CLASSPATH for windows batch scripts Mar 31, 2023
@opax opax reopened this Mar 31, 2023
@aikebah
Copy link

aikebah commented May 13, 2023

@opax On a quick read I think that your patch will break in case of an unset JAVACMD env variable the case of

As JAVACMD, if unset, is set to JAVA_BINARY in the template. If you then later quote JAVACMD it will look for a binary called "start /min javaw" instead of a binary "start" with arguments "/min" and "javaw"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants