Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fx implementation #470

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

feat: fx implementation #470

wants to merge 58 commits into from

Conversation

geka-evk
Copy link
Contributor

@geka-evk geka-evk commented Mar 12, 2024

Changes:

  • Currency Conversion
    • Added support for POST /fxQuotes and /fxTransfers inbound
    • Added support for parties supportedcurrencies & kycinformation
    • Added FX capability for OutboundTransfers
  • Configurable generation of ids (Ex: UUIDv7, ULID)

geka-evk and others added 14 commits November 30, 2023 09:42
… requests (#458)

* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): ignored some vulnerabilities

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-tests for postFxTransfers method

* feat(3618): added FX endpoints to .env

* chore(snapshot): 20.7.0-snapshot.2

* feat(3618): updated @mojaloop/central-services-shared version to support FX resources

* chore(snapshot): 20.7.0-snapshot.3

* feat(3618): disabled @mojaloop/central-services-shared"downgrading" from snapshot version (by dep:update)

* chore(snapshot): 20.7.0-snapshot.4

* feat(3618): added ilp unit-test;  updated Ilp version

* chore(snapshot): 20.7.0-snapshot.5

* feat(3618): updated ilp packet version (with amount)

* chore(snapshot): 20.7.0-snapshot.6

* feat(3618): added extractBodyHeadersSourceFspId()

* add cache implementationf or fxquote

* validate cache on conversionId

* lint

* feat(3618): reverted 3 last commits

---------

Co-authored-by: Aaron Reynoza <[email protected]>
…yc (#459)

* feat: add support for parties supportedcurrencies & kyc

* dep updates and fix unit tests

* update vulnerability check

* move supportedCurrencies to inbound server

* lint

* fix: func tests

* fix: func tests

* feat: refactored

* fix: func tests

* fix: func tests

* fix: add fx func test

* fix: test

* fix: test

* fix: deps

---------

Co-authored-by: Vijay <[email protected]>
…l; small refactoring (#460)

* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): ignored some vulnerabilities

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-tests for postFxTransfers method

* feat(3618): added FX endpoints to .env

* chore(snapshot): 20.7.0-snapshot.2

* feat(3618): updated @mojaloop/central-services-shared version to support FX resources

* chore(snapshot): 20.7.0-snapshot.3

* feat(3618): disabled @mojaloop/central-services-shared"downgrading" from snapshot version (by dep:update)

* chore(snapshot): 20.7.0-snapshot.4

* feat(3618): added ilp unit-test;  updated Ilp version

* chore(snapshot): 20.7.0-snapshot.5

* feat(3618): updated ilp packet version (with amount)

* chore(snapshot): 20.7.0-snapshot.6

* feat(3654): added FX States and Transitions for OutboundTransfersModel;  small refactoring

* feat(3654): added ErrorMessages; updated deps
…tes handler (#461)

* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): ignored some vulnerabilities

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-tests for postFxTransfers method

* feat(3618): added FX endpoints to .env

* chore(snapshot): 20.7.0-snapshot.2

* feat(3618): updated @mojaloop/central-services-shared version to support FX resources

* chore(snapshot): 20.7.0-snapshot.3

* feat(3618): disabled @mojaloop/central-services-shared"downgrading" from snapshot version (by dep:update)

* chore(snapshot): 20.7.0-snapshot.4

* feat(3618): added ilp unit-test;  updated Ilp version

* chore(snapshot): 20.7.0-snapshot.5

* feat(3618): updated ilp packet version (with amount)

* chore(snapshot): 20.7.0-snapshot.6

* feat(3654): added FX States and Transitions for OutboundTransfersModel;  small refactoring

* feat(3654): added ErrorMessages; updated deps

* feat(3654): added fxQuote step to outbound model

* feat(3654): added fxQuotes inbound handler

* fix: fxquotes

---------

Co-authored-by: Vijay <[email protected]>
* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): added support for POST /fxQuotes and /fxTransfers inbound requests

* feat(3618): ignored some vulnerabilities

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-test for postFxQuote model

* feat(3618): added unit-tests for postFxTransfers method

* feat(3618): added FX endpoints to .env

* chore(snapshot): 20.7.0-snapshot.2

* feat(3618): updated @mojaloop/central-services-shared version to support FX resources

* chore(snapshot): 20.7.0-snapshot.3

* feat(3618): disabled @mojaloop/central-services-shared"downgrading" from snapshot version (by dep:update)

* chore(snapshot): 20.7.0-snapshot.4

* feat(3618): added ilp unit-test;  updated Ilp version

* chore(snapshot): 20.7.0-snapshot.5

* feat(3618): updated ilp packet version (with amount)

* chore(snapshot): 20.7.0-snapshot.6

* feat(3654): added FX States and Transitions for OutboundTransfersModel;  small refactoring

* feat(3654): added ErrorMessages; updated deps

* feat(3654): added fxQuote step to outbound model

* feat(3654): added fxQuotes inbound handler

* feat(3654): added fxTransfer flow

* feat(3654): added fxTransfer flow

* fix: lint

* chore(snapshot): 23.2.0-snapshot.1

* fix: deps

* chore(snapshot): 23.2.0-snapshot.2

---------

Co-authored-by: Vijay <[email protected]>
…dlers; added e2e unit-test (#463)

* feat(3654): added cache.subscribeToOneMessageWithTimer();  simplified FX handlers

* feat(3654): added e2e FX transfer unit test

* feat(3654): added e2e FX transfer unit test

* feat(3654): fixed POST /quotes payload.amount for FX
* feat(TestServer): add getFxQuoteQuoteById endpoint
@geka-evk geka-evk changed the title feat(fx-impl) add fx endpoints feat(fx-impl): add fx endpoints Mar 12, 2024
@vijayg10 vijayg10 marked this pull request as draft March 13, 2024 19:11
@geka-evk geka-evk closed this Mar 13, 2024
@geka-evk geka-evk reopened this Mar 13, 2024
kleyow and others added 8 commits June 24, 2024 14:56
…489)

* chore(mojaloop/#3909): add func tests for fx sdk functionality

* chore: fix fx test

* chore: clean up ttk setup

* revert spec and add config to dto

* revert

* bump client lib

* unit

* add error test cases

* yarn lock

* remove unneed specs

* save report

* remove hub unneeded specs
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
3.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@kleyow kleyow marked this pull request as ready for review July 4, 2024 22:42
geka-evk and others added 3 commits August 19, 2024 17:30
* fix(csi-498): added logs to incoming requests

* fix(csi-498): added logs to incoming requests

* fix(csi-498): added logs to incoming requests

* fix(csi-498): added logs to incoming requests

* fix(csi-498): added logs to incoming requests

* chore(snapshot): 23.6.0-snapshot.2

* fix(csi-498): updated central-services-shared version

* chore(snapshot): 23.6.0-snapshot.3
@vijayg10 vijayg10 changed the title feat(fx-impl): add fx endpoints feat: fx implementation Sep 4, 2024
geka-evk and others added 15 commits September 4, 2024 12:47
* fix(csi-532): added logs for restarting

* chore(snapshot): 23.6.0-snapshot.4

* fix(csi-532): added logs for restarting

* chore(snapshot): 23.6.0-snapshot.5

* fix(csi-532): improved BackendRequests logging

* chore(snapshot): 23.6.0-snapshot.6

* fix(csi-532): added OutboundTransfersModel logs with tls.creds

* chore(snapshot): 23.6.0-snapshot.7

* fix(csi-532): improved ControlAgent closing logic

* fix(csi-532): improved ControlAgent closing logic

* chore(snapshot): 23.6.0-snapshot.8

* fix(csi-532): updated deps

* fix(csi-532): updated deps
* fix: jws keys update

* chore: deps

* chore: cleanup
* Add determining transfer id to fxQuoteRequest

* Add patchFxTransfers to InboundServer handlers

* Rename sendNotificationToBackend to sendFxPatchNotificationToBackend

* Add unit test for PATCH fxTransfers of InboundApi

* Add unit test for sendFxPatchNotificationToBackend of InboundTransferModel

* fix: unit test

* fix: unit test , update:mock data for sendFxPatchNotificationToBackend

---------

Co-authored-by: v3-Panwar-Ujjwal <[email protected]>
Co-authored-by: Vijay <[email protected]>
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants