[TRACKING PR] pisp/master #172
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pisp/update/merge master
eoln
requested review from
lewisdaly,
ksatya77,
kleyow,
bothadeon,
sridharvoruganti and
bushjames
* chore(uml): add sequence * chore(gitignore): skip tracking coverage and linting cache * feat(authorizations): first draft of api.yaml for OutboundServer * feat(model/common): simplify toJSON method * chore(uml): add cache part to better understand the flow * feat: Draft of Outbond Authhorization Model * chore(uml): extract pisp sequences to separate file * chore(.gitignore): do not trace .DS_Store * feat(OutbondAuthorizationsModel): implement unit tests * chore: fix linting * feat(OutboundServer/handlers): implement postAuthorization * feat(Outbound/handlers): postAuthorization * chore(uml): thirdparty flows * feat(Inbound/handlers): putAuthorization and ENABLE_PISP_MODE * fix(OutboundAuthorizationsModel.test): fix validation test * test(Inbound/handlers): mockLogger * refactor(PersistenStateMachine): make code simpler * fix(mockLogger): improper mock layout * refactor(OutboundAuthorizationModel): use mockLoggger & make code simpler * test(PUT /authorizations): implement DFSP & PISP tests * refactor(InboundServer/handlers): simplify code * test(OutboundServer/handlers): post /authorizations * fix(OpenAPI): finalise schemas for inbound and outbound servers
* Renamed ALS_ENDPOINT_HOST to ALS_ENDPOINT * Bumped up the version * #1325: Bulk quotes and bulk transfers support (#159) * Initial commit for bulk transfers support * Initial commit for bulk quotes and bulkt transfers support * Complete inbound API bulk quotes implementation * Separate bulk quotes switch base URL * Add postTransfers and getBulkTransfers * Update Outbound API spec with bulk transfers endpoints * Update outbound API spec * Add outbound bulk transfers * Fix API spec bugs * Add bulk party lookup * Whitespace fixes * Add outbound bulk quotes requests * Remove used imports * Add outbound POST bulk transfers handler * Add outboud GET /bulkTransfers/{ID} * Add Jest config for test debugging * Add unit tests for bulk quotes and bulk transfers * Add tests for outbound API. Fix missing specs entries. * Add tests for outbound API /bulkQuotes abd /bulkTransfers * Add inbound GET /bulkQuotes/{ID} * Add unit tests for inbound GET bulkQuotesById, PUT bulkQuotesById, PUT bulkQuotesErrorById * Fix spec description for /bulkTransfers and variable initialization in InboundTransfersModel * Remove unreferenced spec entry. * Updates per code review * Updates per code review * Updates per code review * Add more unit tests for InboundTransfersModel. Mor code review changes * Remodel bulk quotes using single state state-machine pattern * Remodel bulk transfers using state machine pattern. Add GET bulk quotes endpoint * Update API spec * Fix tests * Add more unit tests for InboundTransfersModel * Add unit tests for OutboundBulkQuotesModel * Add tests for OutboundBulkTransfersModel * Fix linting issue * PR review updates. * Remove some IDE auto inserted whitespaces * PR review update Co-authored-by: Sam <[email protected]> * Merge master into pisp: Fixed unit test, linting Co-authored-by: Vijay Kumar <[email protected]> Co-authored-by: Yevhen <[email protected]> Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Sam <[email protected]>
* chore(package): latest sdk-standard-components * chore(package): update deps * unmock sdk-standard-components postAuthorization * update * test: fix broken tests * test: finish integrations tests
* fix: the way how errors are handled at InboundServer * lint: remove not used require
* Added outbound GET thirdparty requests transaction call. * Added post thirdparty requests transaction. * Fixed package.json and tests. * Renamed state. * Updated code.
* fix(thirdparty): rename thirdParty to thirdparty * chore: fix endpoints
* feat(pisp-authorization): extend OutboundAuthorizationModel to call pisp authorization after receiving the quote * lint: fix smells
* feat: PartiesModel * fix: some copy/paste leftovers
* feat: PartiesModel
* fix: some copy/paste leftovers
* feat: implement and test PartiesModel handlers
* test: /parties/{Type}/{ID}/{SubId}
…tion (#223) * feat: PartiesModel * fix: some copy/paste leftovers * feat: implement and test PartiesModel handlers * test: /parties/{Type}/{ID}/{SubId} * fix(parties-model): onRequestPartiesInformation proper signature * lint: fix smells * fix: typo
|
|
* Renamed ALS_ENDPOINT_HOST to ALS_ENDPOINT * Bumped up the version * #1325: Bulk quotes and bulk transfers support (#159) * Initial commit for bulk transfers support * Initial commit for bulk quotes and bulkt transfers support * Complete inbound API bulk quotes implementation * Separate bulk quotes switch base URL * Add postTransfers and getBulkTransfers * Update Outbound API spec with bulk transfers endpoints * Update outbound API spec * Add outbound bulk transfers * Fix API spec bugs * Add bulk party lookup * Whitespace fixes * Add outbound bulk quotes requests * Remove used imports * Add outbound POST bulk transfers handler * Add outboud GET /bulkTransfers/{ID} * Add Jest config for test debugging * Add unit tests for bulk quotes and bulk transfers * Add tests for outbound API. Fix missing specs entries. * Add tests for outbound API /bulkQuotes abd /bulkTransfers * Add inbound GET /bulkQuotes/{ID} * Add unit tests for inbound GET bulkQuotesById, PUT bulkQuotesById, PUT bulkQuotesErrorById * Fix spec description for /bulkTransfers and variable initialization in InboundTransfersModel * Remove unreferenced spec entry. * Updates per code review * Updates per code review * Updates per code review * Add more unit tests for InboundTransfersModel. Mor code review changes * Remodel bulk quotes using single state state-machine pattern * Remodel bulk transfers using state machine pattern. Add GET bulk quotes endpoint * Update API spec * Fix tests * Add more unit tests for InboundTransfersModel * Add unit tests for OutboundBulkQuotesModel * Add tests for OutboundBulkTransfersModel * Fix linting issue * PR review updates. * Remove some IDE auto inserted whitespaces * PR review update Co-authored-by: Sam <[email protected]> * upstream merge * Fix misspelt environment variable * Bug fixes with golden path * Update unit test * Add bulk transfers and bulk quotes to the list of valid headers * added functionality for reserve notificaiton by payee * added enum for support of transfer reserve notification * removed local certs and keys * updated version * requests now respond with .data instead of .body (#182) * requests now respond with .data instead of .body * Fixed test. Fixed (not in the broken sense, but sort of) package version. * fixed lint errors * corrected version * Related to #182, no longer need to parse response data * Updated test * WIP * Basically functions. Needs a little tidy-up. * Made Cache constants read-only on the prototype. Set Redis config when in test mode. Tidied up websocket server creation. Removed koa-websocket and added ws. * Rearranged to make diff easier * Linting * Update sdk-standard-component * Now starting and stopping actual test server in unit tests to enable websocket tests. Added a little logging of client information to websocket connections and disconnections. Waiting for all websocket clients to close before concluding test server shutdown. Wrote tests for test server websockets. * Linting * Added support for specific callbacks and requests * Modified websocket endpoint names to match http endpoint names to streamline migration. Now printing entire x-forwarded-for header as client IP address list per review feedback. * Use process.exit instead of process.exitCode * Use process.exit instead of process.exitCode * Send the message ID to the client (#189) * Update FSPIOP API version * Update src/InboundServer/api.yaml Co-authored-by: Sam <[email protected]> * changed inboud api * Delete launch.json * removed package-lock files * removed more package-locks * added missing header in validateHeaders * changed " to ' on refs * fixed missing # in refs in api.yaml * chore: fix faulty test * chore: update ci * chore: revert logger merge Co-authored-by: Vijay Kumar <[email protected]> Co-authored-by: Yevhen <[email protected]> Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Valentin <[email protected]> Co-authored-by: Rajiv Mothilal <[email protected]> Co-authored-by: Matt Kingston <[email protected]> Co-authored-by: Valentin Genev <[email protected]>
* Renamed ALS_ENDPOINT_HOST to ALS_ENDPOINT * Bumped up the version * #1325: Bulk quotes and bulk transfers support (#159) * Initial commit for bulk transfers support * Initial commit for bulk quotes and bulkt transfers support * Complete inbound API bulk quotes implementation * Separate bulk quotes switch base URL * Add postTransfers and getBulkTransfers * Update Outbound API spec with bulk transfers endpoints * Update outbound API spec * Add outbound bulk transfers * Fix API spec bugs * Add bulk party lookup * Whitespace fixes * Add outbound bulk quotes requests * Remove used imports * Add outbound POST bulk transfers handler * Add outboud GET /bulkTransfers/{ID} * Add Jest config for test debugging * Add unit tests for bulk quotes and bulk transfers * Add tests for outbound API. Fix missing specs entries. * Add tests for outbound API /bulkQuotes abd /bulkTransfers * Add inbound GET /bulkQuotes/{ID} * Add unit tests for inbound GET bulkQuotesById, PUT bulkQuotesById, PUT bulkQuotesErrorById * Fix spec description for /bulkTransfers and variable initialization in InboundTransfersModel * Remove unreferenced spec entry. * Updates per code review * Updates per code review * Updates per code review * Add more unit tests for InboundTransfersModel. Mor code review changes * Remodel bulk quotes using single state state-machine pattern * Remodel bulk transfers using state machine pattern. Add GET bulk quotes endpoint * Update API spec * Fix tests * Add more unit tests for InboundTransfersModel * Add unit tests for OutboundBulkQuotesModel * Add tests for OutboundBulkTransfersModel * Fix linting issue * PR review updates. * Remove some IDE auto inserted whitespaces * PR review update Co-authored-by: Sam <[email protected]> * upstream merge * Fix misspelt environment variable * Bug fixes with golden path * Update unit test * Add bulk transfers and bulk quotes to the list of valid headers * added functionality for reserve notificaiton by payee * added enum for support of transfer reserve notification * removed local certs and keys * updated version * requests now respond with .data instead of .body (#182) * requests now respond with .data instead of .body * Fixed test. Fixed (not in the broken sense, but sort of) package version. * fixed lint errors * corrected version * Related to #182, no longer need to parse response data * Updated test * WIP * Basically functions. Needs a little tidy-up. * Made Cache constants read-only on the prototype. Set Redis config when in test mode. Tidied up websocket server creation. Removed koa-websocket and added ws. * Rearranged to make diff easier * Linting * Update sdk-standard-component * Now starting and stopping actual test server in unit tests to enable websocket tests. Added a little logging of client information to websocket connections and disconnections. Waiting for all websocket clients to close before concluding test server shutdown. Wrote tests for test server websockets. * Linting * Added support for specific callbacks and requests * Modified websocket endpoint names to match http endpoint names to streamline migration. Now printing entire x-forwarded-for header as client IP address list per review feedback. * Use process.exit instead of process.exitCode * Use process.exit instead of process.exitCode * Send the message ID to the client (#189) * Update FSPIOP API version * Update src/InboundServer/api.yaml Co-authored-by: Sam <[email protected]> * changed inboud api * Delete launch.json * removed package-lock files * removed more package-locks * added missing header in validateHeaders * changed " to ' on refs * fixed missing # in refs in api.yaml * Disable test-integration job due to security flaw, re-enable image scan, fix flaky pipeline, and remove trailing whitespace (#193) * Re-enable image scan * Fix indentation * Fix indentation * Revert to npm install and package.json * Add vulnerability check and change pipeline order * Fix YAML * Add audit resolver and switch to package-lock.json * Update license-scan for local image * Update node * Update image-scan * Add script * Downgrade npm-audit-resolver * Attempt Dockerfile fix * Bump cache dependency version * Disable test-integration pending security fix * Remove unused script * Bump patch version for built container change * Add timestamp information to transfer. (#195) * Add timestamp information to transfer. * Fix test cases. * [WIP] added PUT /transfers/transferId handling for notifications to payee (#194) * added PUT /transfers/transferId handling for notifications to payee * changed the error handling logic on sendNotification functionality * added unit tests * added unit tests * added contributors and bumped up version * fixed log added comments removed retry configs Co-authored-by: Valentin <[email protected]> * Enable test-integration job in pipeline (#197) * mege * Add ISO-4217 test currencies to enable production testing scenarios. (#198) * Add ISO-4217 test currencies to enable production testing scenarios. * bump package version * added some comments, fixed typo and version * updated package-lock * rolling back integration.env * rollingback integration.env take 2 * rollback integration.env final * fix .env.example * package-lock fix * fixing linter errors * moved resources_versions mapping into config.js and added unit tests and validation * fixed variables missnaming * removed white spaces * negative test; function rename and change of the return of parse function * fixed linting errors * removed package-lock * made src/package-lock again * Use @mojaloop/sdk-standard-components v11.5.2 (#200) Bumped to 11.2.1 * Bump version * Remove wso2auth from Test Server * Removed vulnerable and unused node-fetch * Bumped version * Try out with direct swagger update * MP-2317: update sdk-standard-components to v11.5.3 * Fix broken tests * Add test for 'addCustomKeys' * Refactor test * Fix unit tests * Minor refactor * Add tests for accented characters validation * Fix lint * Remove unused code * Bump version * Fix version * Added TRANSACTION_REQUESTS_ENDPOINT config option * Bumped up the version * merge with master * merge on * fixed bulk * fixed lint errors * jws key restored * reverted accent character commit * recover * reverted commit * removed openapi * removed openapi tests * fixed failing tests * fixed lint errors * Reorganise internal server API (#207) * Change to external log from sdk-standard-components * Removed some testing-specific configuration * Separated sync and async functionality a bit more clearly * Separate functionality into that which can be reconfigured and that which cannot. Enable reconfiguration. * Lint * Fixed Dockerfile * Separated InboundApi (private) and InboundServer (public) classes * Fixed integration test Dockerfile * Made cache connection/disconnection reentrant * Split logger out of inbound server. Added "check" internal package. * Using npm ci in Dockerfiles * Moved cache creation out of individual servers. Separated TestServer into TestServer, WsServer and TestApi classes. Separated OutboundServer into OutboundServer and OutboundApi classes. * Extracted logger creation from OAuthTestServer * Removed state from logger middleware. Deduped some middleware. * Added new internal package to Dockerfiles * Lint * Partial config restructure for clearer API (#208) * Specify more precise config options to TestServer * Bumped package version * Factored caching into middleware * Began restructuring config per-server * Linting. Updated dependency. * Hoist logging config through levels * Lint * Extract cache connection logic from servers * Removed vestiges of unnecessary functionality * Lint * Removed TLS from TestServer (#213) * Removed TLS from TestServer * Lint * Mp 2375 (#211) * Add ISO-4217 test currencies to enable production testing scenarios. * dont forget to save the model in the cache even if outbound transfer fails. It will be needed for debugging. Co-authored-by: Matt Kingston <[email protected]> * Do not start WSO2 auth unnecessarily * save transfer state if error is thrown in run method (#215) Co-authored-by: Matt Kingston <[email protected]> * Some minor fixes * Silenced tests * Use logger instead of console * Lint * Refactored OAuth test server constructor * bugfix * bugfix * Incorporated new sdk-standard-components functionality into SDK * Bumped package version * Run all tests * Log request retries * Bumped package version * Remove redundant example env vars * fixed config refactoring issue * fixedt typo * Added GET /quotes/{ID} to the inbound API (#228) * Added GET /quotes{ID} * added the error callback * update readme * Added PUT /participants/{Type}/{ID}/{SubId} and PUT /participants/{Type}/{ID}/{SubId}/error (#233) * Added GET /quotes{ID} * added PUT /participants * merge master * delete accidentally added files * chore: update package-lock * chore: fix bad merge code block * chore: fix linting issues * chore: fix faulty test Co-authored-by: Vijay Kumar <[email protected]> Co-authored-by: Yevhen <[email protected]> Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Valentin <[email protected]> Co-authored-by: Rajiv Mothilal <[email protected]> Co-authored-by: Matt Kingston <[email protected]> Co-authored-by: Valentin Genev <[email protected]> Co-authored-by: Kamuela Franco <[email protected]> Co-authored-by: James Bush <[email protected]> Co-authored-by: Vassilis Barzokas <[email protected]> Co-authored-by: Murthy Kakarlamudi <[email protected]> Co-authored-by: vijayg10 <[email protected]> Co-authored-by: shashi165 <[email protected]>
* fix: edit some faulty tests * chore: fix lint
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge!!!
This is a Tracking PR so we can easily keep pisp/master up to date with master.