feat: #2123 Default settlement model #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgenev
requested review from
elnyry-sam-k,
MichaelJBRichards and
millerabel
as code owners
mdebarros
requested changes
Apr 30, 2021
| @@ -522,7 +522,7 @@ The following data is returned for each settlement model in the case of a succes | |||
| | `settlementGranularity` | yes | [String](#string) | Specifies whether transfers are settled one by one or as a batch. Possible values are: <br> `GROSS`: Settlement is executed after each transfer is completed, that is, there is a settlement transaction that corresponds to every transaction. <br> `NET`: A group of transfers is settled together in a single settlement transaction, with each participant settling the net of all transfers over a given period of time.| | |||
| | `settlementInterchange` | yes | [String](#string) | Specifies the type of settlement arrangement between parties. Possible values are: <br> `BILATERAL`: Each participant settles its obligations with each other separately, and the scheme is not a party to the settlement. <br> `MULTILATERAL`: Each participant settles with the scheme for the net of its obligations, rather than settling separately with each other party.| | |||
| | `settlementDelay` | yes | [String](#string) | Specifies if settlement happens immediately after a transfer has completed or with a delay. Possible values are: <br> `IMMEDIATE`: Settlement happens immediately after a transfer has completed. <br> `DEFERRED`: Settlement is managed by the Hub operator on-demand or via a schedule.| | |||
| | `currency` | yes | [CurrencyEnum](#currencyenum) | The currency configured for the settlement model. | | |||
| | `currency` | yes | [CurrencyEnum](#currencyenum) | The currency configured for the settlement model. If it's not defined, the settlement model is Default and all transfers which are in currency that doesn't have associated settlement model, will use the default settlement model. | | |||
There was a problem hiding this comment.
Shouldn't the "yes" here also be a "no"?
Suggested change
| | `currency` | yes | [CurrencyEnum](#currencyenum) | The currency configured for the settlement model. If it's not defined, the settlement model is Default and all transfers which are in currency that doesn't have associated settlement model, will use the default settlement model. | | |
| | `currency` | no | [CurrencyEnum](#currencyenum) | The currency configured for the settlement model. If it's not defined, the settlement model is Default and all transfers which are in currency that doesn't have associated settlement model, will use the default settlement model. | | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited the currency on POST /settlementModels as not required, which reflects Default Settlement Model