fix: mapping fixes for fxQuotes

mojaloop · Oct 14, 2024 · 6091067 · 6091067
2 parents 6b02250 + 073929e
commit 6091067
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/ml-schema-transformer-lib",
-  "version": "0.1.1-snapshot.52",
+  "version": "0.1.1-snapshot.53",
   "description": "Shared component for ML schemas translation",
   "repository": {
     "type": "git",
@@ -51,7 +51,7 @@
   },
   "dependencies": {
     "@mojaloop/central-services-error-handling": "^13.0.1",
-    "@mojaloop/central-services-shared": "^18.9.0",
+    "@mojaloop/central-services-shared": "^18.10.0",
     "@mojaloop/sdk-standard-components": "^19.0.0",
     "map-transform-cjs": "^0.2.0"
   },

diff --git a/src/mappings/fspiopiso20022/fxQuotes.ts b/src/mappings/fspiopiso20022/fxQuotes.ts
@@ -50,7 +50,7 @@ export const fxQuotes = {
     "body.conversionTerms.sourceAmount.currency": "body.CdtTrfTxInf.UndrlygCstmrCdtTrf.InstdAmt.Ccy",
     "body.conversionTerms.sourceAmount.amount": "body.CdtTrfTxInf.UndrlygCstmrCdtTrf.InstdAmt.ActiveOrHistoricCurrencyAndAmount",
     "body.conversionTerms.targetAmount.currency": "body.CdtTrfTxInf.IntrBkSttlmAmt.Ccy",
-    "body.conversionTerms.targetAmount.amount": "body.CdtTrfTxInf.IntrBkSttlmAmt.ActiveOrHistoricCurrencyAndAmount",
+    "body.conversionTerms.targetAmount.amount": "body.CdtTrfTxInf.IntrBkSttlmAmt.ActiveCurrencyAndAmount",
     "body.conversionTerms.expiration": "body.GrpHdr.PmtInstrXpryDtTm"
   } as unknown as TransformObject,
   putError: `{
@@ -86,6 +86,11 @@ export const fxQuotes_reverse = {
   } as unknown as TransformObject,
   put: {
     "$noDefaults": "true",
+    "body.GrpHdr.MsgId": { "$transform": "generateID" },
+    "body.GrpHdr.CreDtTm": { "$transform": "datetimeNow" },
+    "body.GrpHdr.NbOfTxs": { "$transform": "fixed", "value": "1" },
+    "body.GrpHdr.SttlmInf.SttlmMtd": { "$transform": "fixed", "value": "CLRG" },
+    "body.GrpHdr.PmtInstrXpryDtTm": "body.conversionTerms.expiration",
     "body.CdtTrfTxInf.VrfctnOfTerms.IlpV4PrepPacket.condition": "body.condition",
     "body.CdtTrfTxInf.VrfctnOfTerms.PmtId.InstrId": "body.conversionTerms.conversionId",
     "body.CdtTrfTxInf.PmtId.TxId": "body.conversionTerms.determiningTransferId",
@@ -98,8 +103,7 @@ export const fxQuotes_reverse = {
     "body.CdtTrfTxInf.UndrlygCstmrCdtTrf.InstdAmt.Ccy": "body.conversionTerms.sourceAmount.currency",
     "body.CdtTrfTxInf.UndrlygCstmrCdtTrf.InstdAmt.ActiveOrHistoricCurrencyAndAmount": "body.conversionTerms.sourceAmount.amount",
     "body.CdtTrfTxInf.IntrBkSttlmAmt.Ccy": "body.conversionTerms.targetAmount.currency",
-    "body.CdtTrfTxInf.IntrBkSttlmAmt.ActiveOrHistoricCurrencyAndAmount": "body.conversionTerms.targetAmount.amount",
-    "body.GrpHdr.PmtInstrXpryDtTm": "body.conversionTerms.expiration"
+    "body.CdtTrfTxInf.IntrBkSttlmAmt.ActiveCurrencyAndAmount": "body.conversionTerms.targetAmount.amount"
   } as unknown as TransformObject,
   putError: `{
     "$noDefaults": "true",

diff --git a/test/fixtures/index.ts b/test/fixtures/index.ts
@@ -1110,7 +1110,7 @@ export const fspiopIso20022Sources = {
           },
           IntrBkSttlmAmt: {
             Ccy: 'XXY',
-            ActiveOrHistoricCurrencyAndAmount: '23.55'
+            ActiveCurrencyAndAmount: '23.55'
           },
           ChrgBr: 'DEBT'
         }
@@ -1864,12 +1864,18 @@ export const expectedFspiopIso20022Targets = (target: GenericObject) => ({
           },
           IntrBkSttlmAmt: {
             Ccy: 'XXY',
-            ActiveOrHistoricCurrencyAndAmount: '23.55'
+            ActiveCurrencyAndAmount: '23.55'
           },
           ChrgBr: 'DEBT'
         },
         GrpHdr: {
-          PmtInstrXpryDtTm: '2016-05-24T08:38:08.699-04:00'
+          MsgId: getProp(target, 'body.GrpHdr.MsgId'),
+          CreDtTm: getProp(target, 'body.GrpHdr.CreDtTm'),
+          NbOfTxs: '1',
+          PmtInstrXpryDtTm: '2016-05-24T08:38:08.699-04:00',
+          SttlmInf: {
+            SttlmMtd: 'CLRG'
+          }
         }
       }
     },