-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black integration, fixes #1662 #1672
Conversation
@RogerHaase @UlrichB22 See the ran black on all python code commit about how it would look like. |
BTW, we should decide about this rather quickly - this PR is likely conflicting with other PRs a lot. |
IMO the line-length should be set to about 120. It looks like you already specified it, but I did not find the config. |
@UlrichB22 It's there: d6e2137 |
@RogerHaase can you have a look? if there are no objections to the black style, i'ld like to merge this (and also add pre-commit integration of it). |
Looks OK to me. |
rebased onto current master. |
@RogerHaase @UlrichB22 please run this in your workdir after this is merged into master and you updated your local master from github:
If e.g. black has to auto-format something in the pre-commit phase, it aborts the commit. Then you can have a look at the changes (if you like), git add these changes and try committing again (which then should succeed). |
... and other parts of moin import it from here, thus we suppress false positive "unused import" warnings.
squashed together some of the commits. ^^^ |
https://pypi.org/project/black/