This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
Refactor social auth providers #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsargent
commented
Jan 27, 2020
| * @param oauth2InfoDAO The implementation of the delegable OAuth2 auth info DAO. | ||
| * @param openIDInfoDAO The implementation of the delegable OpenID auth info DAO. | ||
| * @return The auth info repository instance. | ||
| * XXX This should be done the same way as HTTP filters. |
There was a problem hiding this comment.
So the theory here is that you should be able to define these from configuration, and have them loaded in by dependency injection automatically: see https://github.com/playframework/playframework/blob/master/core/play/src/main/scala/play/api/http/HttpFilters.scala#L78 for an implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR streamlines and seperates the social auth providers and adds more documentation. It adds Github as an auth provider and provides the icon, and sets up common configuration where there is commonality between providers.