Ensure API returns predefined types #4

moh3a · Sep 21, 2023 · e1b2897 · e1b2897
1 parent 1b0b35c
commit e1b2897
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # ae_sdk
 
+## 0.4.9
+
+### Patch Changes
+
+- Ensure API returns predefined types #4
+
 ## 0.4.8
 
 ### Patch Changes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ae_sdk",
-  "version": "0.4.8",
+  "version": "0.4.9",
   "description": "A simple SDK for Aliexpress (dropshipping and affiliate) APIs.",
   "private": false,
   "main": "./dist/index.js",

diff --git a/src/types/ae.ts b/src/types/ae.ts
@@ -53,6 +53,7 @@ import {
   DS_Shipping_Info_Result,
   DS_Tracking_Info_Params,
   DS_Tracking_Info_Result,
+  DS_Categories_Result,
 } from ".";
 
 export type AE_API_NAMES =
@@ -212,7 +213,7 @@ export type AliexpressMethod<T extends AE_API_NAMES> =
     ? {
         method: T;
         params: Affiliate_Categories_Params;
-        result: Affiliate_Categories_Result;
+        result: DS_Categories_Result;
       }
     : T extends "aliexpress.ds.commissionorder.listbyindex"
     ? {

diff --git a/src/types/ds.ts b/src/types/ds.ts
@@ -8,6 +8,7 @@ import {
   YES_NO,
   AE_Sort_Filter,
   AE_Sort_Promo_Filter,
+  Affiliate_Categories,
 } from ".";
 /**
  *
@@ -674,3 +675,17 @@ export type DS_Tracking_Info_Response =
 export interface DS_Tracking_Info_Result {
   aliexpress_logistics_ds_trackinginfo_query_response: DS_Tracking_Info_Response;
 }
+
+/**
+ * DROPSHIPPER API
+ * CATEGORIES
+ */
+export interface DS_Categories_Result {
+  aliexpress_ds_category_get_response: {
+    resp_result: {
+      resp_code: number;
+      resp_msg: string;
+      result: Affiliate_Categories;
+    };
+  };
+}
diff --git a/src/utils/ds_client.ts b/src/utils/ds_client.ts
@@ -42,9 +42,6 @@ export class DropshipperClient extends AESystemClient {
         data.result.aeop_freight_calculate_result_for_buyer_d_t_o_list = (
           data.result.aeop_freight_calculate_result_for_buyer_d_t_o_list as any
         ).aeop_freight_calculate_result_for_buyer_dto;
-        delete (
-          data.result.aeop_freight_calculate_result_for_buyer_d_t_o_list as any
-        ).aeop_freight_calculate_result_for_buyer_dto;
       }
     }
 
@@ -144,13 +141,19 @@ export class DropshipperClient extends AESystemClient {
 
       let data = response.data.aliexpress_trade_ds_order_get_response.result;
 
-      if ((data.child_order_list as any).ae_child_order_info) {
+      if (
+        data.child_order_list &&
+        (data.child_order_list as any).ae_child_order_info
+      ) {
         data.child_order_list = (
           data.child_order_list as any
         ).ae_child_order_info;
       }
 
-      if ((data.logistics_info_list as any).ae_order_logistics_info) {
+      if (
+        data.logistics_info_list &&
+        (data.logistics_info_list as any).ae_order_logistics_info
+      ) {
         data.logistics_info_list = (
           data.logistics_info_list as any
         ).ae_order_logistics_info;
@@ -171,7 +174,22 @@ export class DropshipperClient extends AESystemClient {
    * @link https://open.aliexpress.com/doc/api.htm#/api?cid=21038&path=aliexpress.ds.category.get&methodType=GET/POST
    */
   async getCategories(args: Affiliate_Categories_Params) {
-    return await this.execute("aliexpress.ds.category.get", args);
+    let response = await this.execute("aliexpress.ds.category.get", args);
+
+    if (
+      response.ok &&
+      (
+        response.data.aliexpress_ds_category_get_response.resp_result.result
+          .categories as any
+      ).category
+    )
+      response.data.aliexpress_ds_category_get_response.resp_result.result.categories =
+        (
+          response.data.aliexpress_ds_category_get_response.resp_result.result
+            .categories as any
+        ).category;
+
+    return response;
   }
 
   /**