Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to win32 5.5.4 #780

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

navaronbracke
Copy link

@navaronbracke navaronbracke commented Aug 28, 2024

This PR migrates flutter_secure_storage_windows to support Dart 3.4.0 / Flutter 3.22.0 (and by extension also Dart 3.5.0 / Flutter 3.24.0)

I did not update the version of flutter_secure_storage_windows, as changing the supported Flutter version could possibly be seen as a breaking change. That said, if we use the new version constraint for the latest Flutter stable across all of flutter_secure_storage, you could also start cleaning up the deprecated usages of describeEnum() (which are the only ignores in this plugin's Dart code AFAIK)

Fixes #779

@@ -3,8 +3,8 @@ description: Demonstrates how to use the flutter_secure_storage_windows plugin.
publish_to: 'none'

environment:
sdk: '>=2.12.0 <3.0.0'
flutter: ">=2.0.0"
sdk: '>=3.4.0 <4.0.0'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns the windows example with the windows implementation.

// TODO: New member requires win32 ^5.4.0
// ignore: deprecated_member_use
ERROR_OUTOFMEMORY,
WIN32_ERROR.ERROR_OUTOFMEMORY,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These TODO's can now be addressed.

@@ -4,8 +4,8 @@ repository: https://github.com/mogol/flutter_secure_storage
version: 3.1.2

environment:
sdk: '>=2.12.0 <4.0.0'
flutter: ">=2.0.0"
sdk: '>=3.4.0 <4.0.0'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the last two Flutter releases (3.22.0 and 3.24.0) are way ahead of the current version range, I opted into updating it here, to match the Dart 3.4.0 requirement for win32.

@navaronbracke
Copy link
Author

@mogol If you could take a look that would be very appreciated!

@chrisdedev
Copy link

I feel like this should be merged since it breaks other platform builds. This issue is effecting my applications that I develop for platforms that don't include windows. Since flutter_secure_storage now contains all supported platforms in one pub this affects the build process on any platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flutter_secure_storage_windows] Migrate to win32 5.5.1 or higher
2 participants