Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstract
This patch provides cmd to delete device permanently in
MogileFS::Worker::Query
.Client-side usage is like following.
implementation detail
Actually. this command keeps the primary key
devid
of specified device in TABLEdevice
that prevents reuse of identical
devid
It moves the
hostid
of specified device to be0
whenhost
id starts from1
.Thus, hosts contains no devices can be removed permanently as well.
This patch also prevents any further interactions with deleted devices (
hostid = 0
)That is, get_all_devices() returns devices with condition
hostid > 0
.It also validates the specified device contains no file, accepts no incoming file, and is marked as dead,
which prevents deleting of incident and implosion of the cluster.