Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display of collections in collection grid #370

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Ruslan-Aleev
Copy link
Contributor

@Ruslan-Aleev Ruslan-Aleev commented Oct 1, 2024

Added the ability to display collections within a collection, in a grid.

In the system settings, you can specify collection templates, separated by commas, that will be displayed within the grid.

Before
before

After
after

#369
#250

@matdave matdave self-assigned this Oct 23, 2024
@theboxer
Copy link
Member

@Ruslan-Aleev Hey, thank you for the PR, but I'm not 100% sure it's usable as is.

  • I feel like this is something the collection's view should control and not a global system setting
  • Right now they are excluded for a reason, if you hit the "Open" button for collection, the view doesn't change, so if your nested collection has a different view (for example different columns, labels, etc.) the view won't load, just the children will show with the current view. Maybe this could be worked around be either not showing the open button, or making it go to the actual resource instead of loading children to the current view

@Ruslan-Aleev
Copy link
Contributor Author

@theboxer

  1. Unfortunately, I did not find a way to display collections without using system settings, because there is a database request.
  2. Yes, I did not pay attention to the "Open" button.
    I did not understand the logic of the "Open" button at all. If the resource is a collection, then it will not be displayed in the grid (this PR fixes this), and if the resource is already in the grid, then a child resource cannot be created for it. Or am I missing something?

In general, I do not know how to fix this PR correctly, maybe you can help. I can make it a draft, should I do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants