Docs upgrade #3370
Open
Docs upgrade #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update links - rewrite some parts
Erb3
suggested changes
Mar 8, 2025
Comment on lines
+1
to
+8
| --- | ||
| title: Ariadne | ||
| description: Ariadne contributing guide | ||
| --- | ||
|
|
||
| The codebase is kept in Modrinth's [monorepo](https://github.com/modrinth/code). You can find it in the [`packages/ariadne`](https://github.com/modrinth/code/tree/main/packages/ariadne) directory. | ||
|
|
||
| Work in progress... |
There was a problem hiding this comment.
There is no ariadne specific setup, doesn't really need it's own page imo.
There was a problem hiding this comment.
I haven't found any content about Aridne the project doesn't even have a readme in the monorepo
Comment on lines
-25
to
-27
| We welcome contributions! Before submitting any contributions, please read our [contributing guidelines](https://docs.modrinth.com/contributing/getting-started/). | ||
|
|
||
| If you plan to fork this repository for your own purposes, please review our [copying guidelines](COPYING.md). |
There was a problem hiding this comment.
Think this generally flows better, and includes the copying guidelines
There was a problem hiding this comment.
I, of course, mentioned the copying guidelines and linked it in the getting started page when you follow instructions on how to setup the monorepo and I think is better than the readme which is just a presentation of the repository
Co-authored-by: Erb3 <[email protected]> Signed-off-by: Tiziano <[email protected]>
Co-authored-by: Erb3 <[email protected]> Signed-off-by: Tiziano <[email protected]>
Co-authored-by: Erb3 <[email protected]> Signed-off-by: Tiziano <[email protected]>
Co-authored-by: Erb3 <[email protected]> Signed-off-by: Tiziano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation general update & related
Consider merging #3342 first (will probably require merge from main)