[Feature] Add modern message styles and link button and inline link support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Sep 18, 2024
src/main/kotlin/me/modmuss50/mpp/platforms/discord/DiscordAPI.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/modmuss50/mpp/platforms/discord/DiscordWebhookTask.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/modmuss50/mpp/platforms/discord/DiscordWebhookTask.kt
Outdated
Show resolved
Hide resolved
- Added modern message style - Improved support for message components - Added tests for the new styles - Added support for components with classic message body
Awakened-Redstone
changed the title
|
The main PR comment has been updated to better reflect the changes from the last commit |
|
Weird, the tests passed locally, and the components ones should pass, I made the internal server return that the webhook is application owned |
|
Why is DryTest running, it should have been ignored |
|
this should fix it |
Awakened-Redstone
changed the title
modmuss50
reviewed
Oct 21, 2024
Comment on lines
91
to
93
| @JvmField | ||
| @Suppress("MemberVisibilityCanBePrivate") | ||
| protected val style: MessageStyle = MessageStyle() |
There was a problem hiding this comment.
This isnt right, this should be a @Nested Property<MessageStyle>
There was a problem hiding this comment.
I wasn't able to get it working with @Nested, this was the best I was able to do
Comment on lines
53
to
54
| @Suppress("MemberVisibilityCanBePrivate") | ||
| class MessageStyle internal constructor() : java.io.Serializable { |
There was a problem hiding this comment.
This should be an interface or abstract class, using Gradle properties, let me know if you want me to make this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classic message body
Modern message body