Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC sequence of G0 (and C0) devicec have wrong channel shift? #1197

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Apehaenger
Copy link
Contributor

@Apehaenger Apehaenger commented Aug 12, 2024

While still working on my STM32C0x implementation #1188, I had a head-cruncher by building a ADC-Sequence example.
For me it looks like the implementation is wrong as it shifts the ADC channel only by 1 bit instead of 4.
So in my opinion ADC sequences can't work for F0, G0 as well as C0 devices?!

ext/modm-devices Outdated Show resolved Hide resolved
@Apehaenger Apehaenger marked this pull request as ready for review August 12, 2024 20:31
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Register layout from the G0 manual for reference:
Screenshot_20240812_225400

The unrelated submodule update is still there. Could you remove it?

@Apehaenger
Copy link
Contributor Author

Apehaenger commented Aug 12, 2024

The register layout for C0 look equal.

Regarding the unrelated submodule:
I would be happy if I could, but I'm unsure how ;-)
Rewind my modm-device submodule to standard and commit again?

Done

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium salkinium merged commit 3c039d9 into modm-io:develop Aug 13, 2024
12 checks passed
@Apehaenger Apehaenger deleted the bugfix/adc-chselr branch August 13, 2024 13:31
@salkinium salkinium added this to the 2024q3 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants