Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27 Several graph algorithms including cycle checks #40

Merged
merged 10 commits into from
Jan 27, 2019

Conversation

gunnarmorling
Copy link
Member

Supersedes #31, but only style changes so far:

  • No $%§!! Windows line-breaks; also added .gitattributes to ensure line breaks are nomalized in the repo
  • Avoiding dependency to Guava
  • Formatting

@gunnarmorling
Copy link
Member Author

Hey @wuetherich and @nilshartmann, it's still work in progress, but some first success with hooking up the cycle detection algorithm with the rest of Deptective:

mapstruct-deptective

@gunnarmorling
Copy link
Member Author

I'm going to merge this one. The implementation isn't ideal yet, but it's doing the job well enough. The following behavior has been implemented:

  • During VALIDATE mode, any cycles in the architecture model (deptective.json) will cause a build error by default (can be changed to warning via -Adeptective.cycle_reporting_policy). That is because the target model shouldn't contain cycles. Note that any unintended relationships in the actual code that form a cycle will be report as an illegal dependency just as before.
  • During ANALYZE mode, any cycles in the actual code base will cause a build warning. The model should be altered to break up the cycle before validating against it.

Thanks a lot for the algorithm implementation, @wuetherich!

@gunnarmorling gunnarmorling merged commit 5579e11 into moditect:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants