-
Notifications
You must be signed in to change notification settings - Fork 653
Modin Core
Vasily Litvinov edited this page Jun 29, 2021
·
1 revision
- Modin Core is the collection of people who are actively maintaining the Modin project and governing its code going forward
- Criteria for admitting to the Core:
- 50+ commits in the main (core) part of Modin
- 50+ pull request reviews done
- Shown understanding of the general architecture and core architecture
- Positive attitude towards the community
- Small guide on merging a pull request (PR):
- We always squash and merge, but when you first click to do so in the GitHub UI, you will see a text box that basically appends all commit messages together. Delete everything except for the signed off and coauthored by lines (non duplicate). This is a good example that had multiple authors: https://github.com/modin-project/modin/commit/64d6cb064feac23ed5bfa0cba221f35c512c114e
- Note: if you feel that PR title is not descriptive enough you should suggest changing (or edit yourself) the PR title first. If the change being merged is still big and can not be shown in one short sentence you should try to summarize the PR message (but don't just include all the commit messages as it only creates visual clutter).
- Be very conservative and cautious about merging things that change lower levels. If you have any questions or uncertainties don't hesitate the other Core members
- Try to keep PRs as small as possible, and don't be afraid to suggest to break up a large PR. One PR should be making one semantically atomic change, even if that means we'd need to make 5 PRs to change 5 lines of code.
- We always squash and merge, but when you first click to do so in the GitHub UI, you will see a text box that basically appends all commit messages together. Delete everything except for the signed off and coauthored by lines (non duplicate). This is a good example that had multiple authors: https://github.com/modin-project/modin/commit/64d6cb064feac23ed5bfa0cba221f35c512c114e