Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#7375: Fix Series.duplicated dropping name #7395

Merged

Conversation

noloerino
Copy link
Collaborator

What do these changes do?

Series.duplicated uses DataFrame.duplicated in implementation, but since this drops the original Series's name, we need to manually restore it after the computation.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Series.duplicated doesn't preserve Series name #7375
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

modin/pandas/series.py Outdated Show resolved Hide resolved
Co-authored-by: Anatoly Myachev <[email protected]>
@anmyachev anmyachev merged commit 05f5e7d into modin-project:main Sep 14, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.duplicated doesn't preserve Series name
2 participants